Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented signals for import-feature-flag #2086

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Conversation

RidhamShah
Copy link
Collaborator

@RidhamShah RidhamShah commented Oct 30, 2024

Used signals with componentStore to call import-feature-flag-api instead of directly calling API and using local store.

Doc - https://ngrx.io/guide/component-store
(Just FYI, componentStore and SignalStore are 2 different things)

@VivekFitkariwala
Copy link
Collaborator

@RidhamShah, I am not sure if I understood this PR. The goal was to move the component-specific state and dataService calls to the component store. There are two requests: validation and import. Both of these calls are not updating the main store as after the import, we are calling this.featureFlagsService.fetchFeatureFlags(true); to fetch all the feature flags. At the end of the PR, the component should not have featureFlagsService and featureFlagsDataService. The isLoadingImportFeatureFlag attribute in the feature flag model should also be removed.

Copy link
Collaborator

@VivekFitkariwala VivekFitkariwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes before I can approve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants